[ui] Reconstruction: Restore the Slot status of the clear method#2732
Merged
[ui] Reconstruction: Restore the Slot status of the clear method#2732
Slot status of the clear method#2732Conversation
cbentejac
requested review from
Copilot,
fabiencastan,
mh0g,
nicolas-lambert-tc and
servantftransperfect
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores the slot functionality for the Reconstruction.clear() method to re-enable its calling from QML.
- Restores the @slot() decorator on the clear() method
- Fixes the UI "Home" button functionality by ensuring clear() is callable via QML
Comments suppressed due to low confidence (1)
meshroom/ui/reconstruction.py:521
- Ensure that the Slot decorator is correctly imported from the appropriate module (e.g., PySide2.QtCore or PyQt5.QtCore) to maintain consistency with the rest of the codebase.
@Slot()
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2732 +/- ##
========================================
Coverage 77.11% 77.11%
========================================
Files 41 41
Lines 6166 6166
========================================
Hits 4755 4755
Misses 1411 1411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mh0g
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue introduced in cfd2b1e which changes the
clear()method from theReconstructionclass from a slot to a regular method.If
clear()is not a slot, it cannot be called from the QML side. In practice, it made the "Home" button ineffective from the Application; once the Homepage had been left, it could not be returned to.